search

requirejs / almond

A minimal AMD API implementation for use after optimized builds
Other
2.42k stars 168 forks source link

Your js script is crashing Firefox #114

Closed joyseeker closed 8 years ago

joyseeker commented 8 years ago

I'm writing as a user here, but I'm a Drupal developer. Your js script is crashing Firefox. I have no idea which website is using it, but in Windows 10, Firefox, twice today I've gotten the script running error dialog box, and this time I said debug script, and I got the link to your github page. Please, please fix the script or catch script errors to let Firefox continue without crashing!! The debug script window is gone, but it was a js script.

Susan Shemin

jrburke commented 8 years ago

Is there a URL I could use to see the issue? This is not the normal behavior of the script, it is likely due to the specific use, so an example or test case would be helpful to determine the cause.

joyseeker commented 8 years ago

Thanks for answering.  When I debugged the script in a window (Firebug?  Firefox debug?) there was no URL anywhere.  Believe me, I looked so I could notify (ah, yell at) the website. Also afterward, I could still use Firefox, but it was extremely slow.  And the currently displayed webpage did not have a tab.  All very strange behavior.  Finally, Firefox just said it had to close. Maybe add a notification in your script to notify you that something isn't going right when the script doesn't run properly?  I sometimes would put a php script in to put an entry into my database when a page was displayed.

Anyway, thanks for answering, and if I see it again, I'll notify you. Susan

  From: James Burke <notifications@github.com>

Sent: Wednesday, March 9, 2016 10:35 PM Subject: Re: [almond] Your js script is crashing Firefox (#114)

Is there a URL I could use to see the issue? This is not the normal behavior of the script, it is likely due to the specific use, so an example or test case would be helpful to determine the cause.— Reply to this email directly or view it on GitHub.

jrburke commented 8 years ago

Sounds good. I am going to close the issue for now, but that just means I cannot immediately act on it without more information. Please continue to use this ticket for discussion of the problem though, and if we get a test case sorted out, then we can easily reopen the issue to track a fix.