rero / ng-core

Angular library for Invenio
4 stars 12 forks source link

editor: speed up the editor #446

Closed jma closed 3 years ago

jma commented 3 years ago

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

How to test?

Code review check list

ThierryClavel commented 3 years ago

premières constatations :

iGormilhit commented 3 years ago

@jma

I've succeded to create a very simple document, editing only the displayed and required fields: https://ilsdev.test.rero.ch/global/documents/2012405.

But if I try to select Niveau minimal in encoding level field, I get the following error:

'Core leve' is not one of ['Full level', 'Full level, material not examined', 'Less-than-full level, material not examined', 'Abbreviated level', 'Core level', 'Partial (preliminary) level', 'Minimal level', 'Prepublication level', 'Unknown', 'Not applicable'].

I do think it's not an editor issue, but a data issue. Further more, Core leve misses the trailing l: Core level.

Screenshot 2021-09-07 at 04-54-32 Admin

Then, I duplicated the document to extend it: https://ilsdev.test.rero.ch/global/documents/2012406.

I could add fields from the left list, search for new fields in the left list (such as mention de responsabilité). With some concepts (sujets), opening the document in the editor takes as long as 1 second.

The only issue I encounter is with fields such as Genre, forme or Sujet that can search for concepts on MEF. But it's not working on https://ils.test.rero.ch either.

Then I could add an item and a serial holdings with a prediction.

A document imported from the BnF: https://ilsdev.test.rero.ch/global/documents/2012409.

No issue when creating a new patron: https://ilsdev.test.rero.ch/professional/records/patrons/detail/55.

Also tested without issue the circulation policies editor, the patron type editor.

JoelleDosimont commented 3 years ago

Some comments:

ThierryClavel commented 3 years ago

Import from the Web : I have this error when recording document. https://ilsdev.test.rero.ch/professional/records/documents/new?source=bnf&pid=FRBNF311488500000004. If I complete the field, I can save record image

ThierryClavel commented 3 years ago

creation of record document : "encoding level field: If I choose "Niveau de base" : I have an error. If I choose "Niveau complet" I can save record normally