rero / rero-ils

Integrated Library System flavour of Invenio by RERO+.
http://ils.test.rero.ch
GNU Affero General Public License v3.0
72 stars 27 forks source link

Renew all from the patron profile #2334

Open jma opened 3 years ago

jma commented 3 years ago

It would be great that the patron can be renew all the current loaned items at once.

Describe the solution you'd like

In the public view, patron account, loans tab:

Note: suggested by a patron (F. M.)

zannkukai commented 2 years ago

@pronguen The "loan" tab of patron profile use a paginator to limit loans number. Are you agree if the "renew all" button only apply on loans of the current page ? If not, it will be very difficult/time consuming to display or hide the button because we need to check all loans from all pages (despite the paginator, we need to load all loans everytime).

Maybe we need to discuss about that during a daily meeting or a PO metting

pronguen commented 2 years ago

@zannkukai I think the user expect, when clicking on "Renew all", that all loans are renewed. Would it be easier to always enable the button and to give a feedback after the action? Ex: "3 loans have been renewed, 6 loans couldn't be renewed."

zannkukai commented 2 years ago

@pronguen I had some discussion about this issue with @jma and @Garfield-fr. It seems important to have more informations about the whished behavior. Depending of the behavior, we could choose a way to code this feature. It seems this feature could be an US candidate.

Now, we can imagine some behavior :

Maybe it should be discussed in next PO meeting ?

pronguen commented 2 years ago

add a button "renew all" --> open a modal with a spinner (to notify that work is in progress) + display of renew error into this modal. Could be slow if user has a lot of loan (300+) because it will send 300+ "renewOne" command.

@zannkukai After discussion with PO group, we think this solution (above) is the best. Indeed, the patrons with a lot of loans are exceptions, and usually, they won't need to renew all loan in a batch. Here, renewal should work well with up to 20 loans, last a bit with 20-40 loans, and with more... this is the exception.

github-actions[bot] commented 9 months ago

This issue is stale because it has been open 6 months with no activity.

github-actions[bot] commented 1 week ago

This issue is stale because it has been open 6 months with no activity.