rero / rero-ils

Integrated Library System flavour of Invenio by RERO+.
http://ils.test.rero.ch
GNU Affero General Public License v3.0
72 stars 27 forks source link

Librarians should receive a notification when an item arrives at desk #2695

Closed ManaDeweerdt closed 2 years ago

ManaDeweerdt commented 2 years ago

Describe the bug

For now, the booking notification is sent after a checkin action, when there is a pending loan. This does not completely meet the needs because:

Expected behavior

  1. Create a notification at_desk
    • it is sent when a loan arrives "ITEM_AT_DESK" (same condition that triggers the availability notification, with an eventual delay configured)
  2. Add a new template for this notification (see below)
  3. Adapt the library notification settings to add this notification type. As for availability, it should contain the "delay" field.

Difference with the availability notification

TEMPLATE: at_desk.odt OVERVIEW OF NOTIFICATION SPEC: spec_impressions.odt

PascalRepond commented 2 years ago

To me, this is not a bug. By definition a transit or booking notification shouldn't happen on request validation. See specs here: https://bib.rero.ch/help/circulation/#notifications-de-circulation I think this is also what causes misunderstandings in #2707

pronguen commented 2 years ago

This issue has been re-written according to a discussion in the PO group.