rero / rero-ils

Integrated Library System flavour of Invenio by RERO+.
http://ils.test.rero.ch
GNU Affero General Public License v3.0
72 stars 27 forks source link

Document import: subject `creator` is unexpected #3468

Closed PascalRepond closed 11 months ago

PascalRepond commented 1 year ago

Bug description:

When importing a document with a subject of type Work that has a creator (MARC subfield ?), the importer tries to create a subfield subjects_imported.entity.creator that is not accepted by the jsonschema. This creates an error when trying to save the document.

Relates to

Expected behavior:

In this case, the document importer should create a unique authorized_access_point from the MARC fields without creating an invalid "creator" subfield in the json.

Format of the authorized access point : TO BE DEFINED

Steps to Reproduce:

  1. Try to import this document from SLSP : https://ils.test.rero.ch/professional/records/documents/new?source=slsp&pid=991171187128205501
  2. Check "network" inspector and see the incorrect json
  3. Try to save and see the error

Version:

v1.18.0

Anything else?

⚠️ : Check that other importer versions (LoC, etc...) also avoid this error.

PascalRepond commented 1 year ago

Exact specifications for work subjects imports should be clarified between @rerowep and @Ewa666