Rename and extend document schema and mapping.

rero / reroils-data-legacy

Data module for reroils-app.

GNU General Public License v2.0

5 stars 5 forks source link

Rename and extend document schema and mapping. #42

Closed iGormilhit closed 5 years ago

iGormilhit commented 5 years ago

This two commits concern the taiga task 609. :warning: There's also a PR in reroils-app

The first commit renames book to document, and the second adds the type and is_part_of fields in the schema and adapts the document mapping.

To test it.

Fetch the pull requests.
Run the populate script and verify that the resources are existing and indexed.
Run the tests.

Signed-off-by: Igor Milhit igor.milhit@rero.ch Co-authored-by: Nicolas Labat nicolas.labat@rero.ch

iGormilhit commented 5 years ago

When looking for the string book to replace it by document, we notice that the file documents/dojson/contrib/unimarctojson/model.py still mention bibliomedia.

https://github.com/rero/reroils-data/blob/db263b4240adecba2d40745f894963c8c5d099c3/reroils_data/documents/dojson/contrib/unimarctojson/model.py#L3

https://github.com/rero/reroils-data/blob/db263b4240adecba2d40745f894963c8c5d099c3/reroils_data/documents/dojson/contrib/unimarctojson/model.py#L6

Should we correct this in this commit?

rerowep commented 5 years ago

Yes, I think it is a good idea to correct it.

iGormilhit commented 5 years ago

@rerowep Ok, the headers are corrected.

BadrAly commented 5 years ago

Tests are OK
Populate.sh will fail. need to have the dojson task done before the integration of this PR.