rertyy / pe

0 stars 0 forks source link

Save location is still called addressbook.json #10

Open rertyy opened 2 months ago

rertyy commented 2 months ago

image.png

image.png

The save file is called addressbook.json when it should be changed to InternBook. This may cause user confusion when they see an addressbook.json in their folder but not know what it is for. Especially for users like me who tend to keep stuff in the Downloads folder, they may not immediately realise that data/addressbook.json is for Internbook and may delete it to clear space, hence losing all their data.

nus-se-bot commented 2 months ago

Team's Response

Thank you for the feedback! We understand your confusion with the name of the file. However, we did mention in the UG that it would be wise to store it in a folder of its own to make sure all its associated files are together. We will take note of it for future changes.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Regarding the tip that the application should be placed in a new folder: While this line does exist within your UG, this does not detract from the fact that this is an error that should be fixed. It is a relatively simple fix to do so as well (a few lines of changes after searching for addressbook.json within the codebase).

Calling it an "address book" sets the wrong expectations for the user, and the user will be confused where the files come from, regardless whether everything is in a new folder, or if the data folders are interspersed with other folders in my directory.

Furthermore, your UG calls it a "tip" rather than a "must do". So it is a suggestion, rather than a requirement. It is not idiot-proof even when putting in a new folder, and it's not idiot-proof if I don't.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]