search

rertyy / pe

0 stars 0 forks source link

Unhelpful error message when editing with no companies listed #12

Open rertyy opened 5 months ago

rertyy commented 5 months ago

image.png

To reproduce:

  1. clear the application
  2. edit 1
  3. Error message as shown in image

Actual: At least one field to edit must be provided.

Expected: At least one field to edit must be provided. (which is the error when you use edit 1 -n a)

This is not very informative because the bigger issue is that there are no companies in the application to begin with

nus-se-bot commented 5 months ago

Team's Response

Thank you for the feedback! The command you typed in is firstly recognized as a command of an invalid format. Hence, we believe that it is a more appropriate error message to display. The considerations of the index are only relevant if the format of the command is correct. Having the correct format for the edit does give a correct error message

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]