search

rertyy / pe

0 stars 0 forks source link

[DG] No mention of ReminderWindow #24

Open rertyy opened 2 months ago

rertyy commented 2 months ago

image.png

ReminderWindow is in your diagram but there is no mention of it anywhere in the DG.

Also notice that you mention the composition relation of MainWindow with all the other components but ReminderWindow does not have a composition relation, so means that it is not subsumed under the etc.

I'm putting this as low because new developers will not know how ReminderWindow is integrated with the rest of the application.

nus-se-script commented 2 months ago

Team's Response

Thank you for the feedback! We fully intended for both HelpWindow and ReminderWindow to be included in the etc, although we do agree that we should be more explicit to make it very clear to users.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: If you intended for both to be included within the etc, doesn't that make your diagram wrong? Hence, this makes it even less NotInScope, but something that should have been fixed.

As explained initially, "is made up of parts" suggests a composition relationship. HelpWindow and ReminderWindow do not have a composition relation with MainWindow, as shown in your diagram.

Hence, this is not a matter of being explicit or not, but that either your DG explanation or your diagram is wrong. Your diagram looks correct to me, so it is likely your DG explanation is wrong.