search

rerun-io / grounding-sam

Demo combining Grounding DINO with SAM (Segment Anything Model) visualized with Rerun
MIT License
2 stars 1 forks source link

Alternative path for Grounding Sam demo #2

Closed nikolausWest closed 1 year ago

nikolausWest commented 1 year ago

@pablovela5620 I started playing around with the demo and ended up diverging enough that it maybe makes more sense in it's own PR / branch. My original idea of using multiple prompts went a bit against the grain of how Grounding Dino works (where it separates out the phrases per detection) so I unified it to just use one. After doing that it was clear it made more sense to do much simpler logging / data hierarchy structure as well.

What do you think?

pablovela5620 commented 1 year ago

This feels a lot cleaner, especially for the data hierarchy, I will say that for me personally the prompting is a bit more confusing (I preferred sending in the individual prompts "dog" "woman" etc.. but I think this is personal preference), but I think it's worth the change. I like this implementation better