rerun-io / python-example-droid-dataset

Visualizing the DROID dataset using Rerun
51 stars 4 forks source link

Drag robotiq_arg85_description via requirements.txt #3

Open Wumpf opened 7 months ago

Wumpf commented 7 months ago

this repo embeds https://github.com/a-price/robotiq_arg85_description right now. Submodules are too hard to use (making the example setup longer) but this could also be dragged in via pip if I'm not mistaken

02alexander commented 7 months ago

It used to be a submodule but I thought I fixed that, what did I miss? The reason I copy pasted it is that I had to make a small modification to combine it with the Franka .xacro file, perhaps I could have let it be a separate URDF model and then log both of them, but I thought it would be nicest to have a single URDF file that could be loaded.

Wumpf commented 7 months ago

you didn't miss anything, it's not a submodule and I was trying to say it's good that way. But I think this could also be done via a pip git dependency, no?

02alexander commented 7 months ago

I'm not familiar with using pip to install non-python packages. Is it possible to tell pip to download the repository and apply my patch?

02alexander commented 7 months ago

Although I suppose that the patch was only needed when I was compiling the .xacro files, right now I just need access to the meshes