rerun-io / rerun

Visualize streams of multimodal data. Fast, easy to use, and simple to integrate. Built in Rust using egui.
https://rerun.io/
Apache License 2.0
6.39k stars 312 forks source link

Min-max range for Turbo colormap doesn't make sense for depth images #1588

Closed nikolausWest closed 1 year ago

nikolausWest commented 1 year ago

Depth images logged as int16 currently get a way too high-max value for colormaps (Turbo only in 2D views). This makes the colormaps close to useless as they end up giving close to uniform colors.

Examples: 2D view

Screenshot 2023-03-14 at 17 01 06

Same depth image backprojected with Turbo colormap

Screenshot 2023-03-14 at 17 00 49
emilk commented 1 year ago

I fail to reproduce.

This is nyud, with the points invisible, and Backproject Depth turned on:

image

The turbo colormap works well, and the 2D view has no colormap, since we haven't gotten to that yet:

nikolausWest commented 1 year ago

@emilk

I'll get an easier repro for you asap but in the mean time, has something changed so we don't use turbo by default for depth images? We set turbo as default for depth images here:

emilk commented 1 year ago

We seem to only use it onlyfor float depth images, not integer depth images. I can make a fix for that.

nikolausWest commented 1 year ago

For repro, just try:

emilk commented 1 year ago

arkitscenes have somehow been fixed by my recent PRs:

image

I'll merge main into the branch

nikolausWest commented 1 year ago

arkitscenes have somehow been fixed by my recent PRs:

Fantastic! Best kind of fix =)