search

rerun-io / rerun

Visualize streams of multimodal data. Free, fast, easy to use, and simple to integrate. Built in Rust.
https://rerun.io/
Apache License 2.0
6.67k stars 336 forks source link

Support light mode in re_ui/re_viewer #3058

Open edulecom opened 1 year ago

edulecom commented 1 year ago

Hello,

I'm playing with .\rerun\crates\re_ui\examples\re_ui_example.rs and I'm trying to change the theme to light. I have added only one line in the fn update:

    egui::TopBottomPanel::bottom("bottom_panel")
        .frame(self.re_ui.bottom_panel_frame())
        .show_animated(egui_ctx, self.bottom_panel, |ui| {
            ui.strong("Bottom panel");
            egui::widgets::global_dark_light_mode_buttons(ui); // this line is added
        });

Effect is strange: only central panel applies the theme. It can be seen in an attached video. Any help would very appreciated.

https://github.com/rerun-io/rerun/assets/104624770/cf9a8e50-f6f1-4a7d-be5d-a5ce285be531

Wumpf commented 1 year ago

The out of the box theme settings are bound to not work properly in rerun as we sadly change a lot of the theming colors in Rerun on-the-fly. At least I suspect that's what's most of the issue here.

That said, (re)adding a light mode is something we want to do eventually. Are you just trying out things or is a Rerun light theme something you'd like to have as well?

edulecom commented 1 year ago

Thank you for your response. I'm currently in the process of developing an app using re_ui, and while the absence of a light mode isn't a critical issue, having that feature would certainly be a welcome addition.