search

rerun-io / rerun

Visualize streams of multimodal data. Free, fast, easy to use, and simple to integrate. Built in Rust.
https://rerun.io/
Apache License 2.0
6.48k stars 319 forks source link

Save dialog on web is really confusing #7138

Open emilk opened 2 months ago

emilk commented 2 months ago

Visit https://rerun.io/viewer

Open any example, then Click "Rerun -> Save recording"

image

You'll see this popup:

image

When clicking "Ok", nothing happens.

I wonder if we really need that extra popup that rfd presents. We should be able to just prompt the download of the data on the first click instead.

jprochazk commented 2 months ago

It works if you click on the click here to download your file text, I'm guessing the Ok there is just to close the dialog without downloading the file.

emilk commented 2 months ago

Oh no… ok, that confused the hell out of me. We should make a PR to rfd to improve this (unless it is already fixed in the latest version).

What do you think about the possibility of being able to directly start the file download on the first click – what would be required for that?

jprochazk commented 2 months ago

What do you think about the possibility of being able to directly start the file download on the first click – what would be required for that?

There was some PR in progress for that:

Looks like it stalled though

jprochazk commented 2 months ago

Posted my thoughts in the original issue: https://github.com/PolyMeilex/rfd/issues/128#issuecomment-2286581683

TL;DR: We could use better APIs in Chromium-based browsers, and otherwise fall back to the existing implementation