Make it possible to look up ComponentName without interning the string

rerun-io / rerun

Visualize streams of multimodal data. Fast, easy to use, and simple to integrate. Built in Rust using egui.

https://rerun.io/

Apache License 2.0

6.43k stars 313 forks source link

Make it possible to look up ComponentName without interning the string #7699

Open jleibs opened 1 week ago

jleibs commented 1 week ago

In theory if I have a string I should be able to hash it and find the corresponding value in a BTreeSet<ComponentName>, however in practice to find the value in the set I have to create a ComponentName which does the interning.

kpreid commented 1 week ago

At a glance, I think that to make this possible, what you need is:

pub struct UninternedString(str);
impl Hash for UninternedString { /* mimic impl Hash for InternedString */ }
impl Borrow<UninternedString> for InternedString
impl AsRef<UninternedString> for &str (must not be Borrow since it hashes differently)