rerun-io / rerun

Visualize streams of multimodal data. Free, fast, easy to use, and simple to integrate. Built in Rust.
https://rerun.io/
Apache License 2.0
6.7k stars 341 forks source link

Warn when `Geo*` entities are logged and the viewer wasn't compiled with the `map_view` feature #8052

Closed abey79 closed 2 weeks ago

abey79 commented 3 weeks ago

The map view is behind a map_view cargo feature on rerun-cli, which is enabled in release build but not in default build (aka when building from source). This leads to a footgun where people don't see a map when they expect one. We should warn the user when that happens, indicating that the map_view feature needs to be enabled.

The proposed mechanism for that is to have a store subscribers that reacts to some specific indicator components, and emit warnings as required.

Level 1: hard code GeoPoints and GeoLineStrings (subject to bitrot, eg when we introduce GeoPolygons

Level 2: use the information already contained in attribute.docs.view_types to populate the reflection structures, and use said structure to generate warnings for all kinds of view that might be missing. . . .

Level ∞: "unsupported data, click here to download the Map view plugin"