rerun-io / rerun

Visualize streams of multimodal data. Free, fast, easy to use, and simple to integrate. Built in Rust.
https://rerun.io/
Apache License 2.0
6.68k stars 337 forks source link

Fix video backward seeking / stepping back sometimes getting stuck (in the presence of b-frames) #8053

Closed Wumpf closed 2 weeks ago

Wumpf commented 2 weeks ago

What

Our PTS -> sample search algorithm wasn't quite right. Fixed this here and added a unit test. Unfortunately, I had to introduce a small auxiliary data structure to keep this snappy / not O(n) for n samples, but it's very simple and rather contained.

Tested on native & web. Web still suffers from

but on Chrome this works fine now!

https://github.com/user-attachments/assets/7a20467d-4d66-456f-be99-debba4ff7a31

Checklist

To run all checks from main, comment on the PR with @rerun-bot full-check.

Wumpf commented 2 weeks ago

known issue on error[unmaintained]:instantis unmaintained