Closed Wumpf closed 2 weeks ago
Our PTS -> sample search algorithm wasn't quite right. Fixed this here and added a unit test. Unfortunately, I had to introduce a small auxiliary data structure to keep this snappy / not O(n) for n samples, but it's very simple and rather contained.
Tested on native & web. Web still suffers from
but on Chrome this works fine now!
https://github.com/user-attachments/assets/7a20467d-4d66-456f-be99-debba4ff7a31
[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):
main
nightly
[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!
[x] If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide
CHANGELOG.md
PR Build Summary
Recent benchmark results
Wasm size tracking
To run all checks from main, comment on the PR with @rerun-bot full-check.
@rerun-bot full-check
known issue on error[unmaintained]:instantis unmaintained
error[unmaintained]:
is unmaintained
What
Our PTS -> sample search algorithm wasn't quite right. Fixed this here and added a unit test. Unfortunately, I had to introduce a small auxiliary data structure to keep this snappy / not O(n) for n samples, but it's very simple and rather contained.
Tested on native & web. Web still suffers from
but on Chrome this works fine now!
https://github.com/user-attachments/assets/7a20467d-4d66-456f-be99-debba4ff7a31
Checklist
[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):
main
build: rerun.io/viewernightly
build: rerun.io/viewer[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!
[x] If have noted any breaking changes to the log API in
CHANGELOG.md
and the migration guidePR Build Summary
Recent benchmark results
Wasm size tracking
To run all checks from
main
, comment on the PR with@rerun-bot full-check
.