search

resbazaz / website

Gather together a group to skill-share, co-work, and create community
https://researchbazaar.arizona.edu/
2 stars 13 forks source link

Switch from google calendar to tui calendar #25

Closed kelseygonzalez closed 3 years ago

kelseygonzalez commented 3 years ago

switch from google calendar to tui calendar. I have not previewed locally to make sure it looks right, so if you want to run jekyll before accepting PR go for it.

kelseygonzalez commented 3 years ago

tagging @alex-r-bigelow and @zoidy since I'm not a maintainer in this repo!

alex-r-bigelow commented 3 years ago

This looks cool!

It looks like the colors / typography got lost from the google doc?

In case it helps, the rest of the page uses Roboto Slab, and here's a color swatch based on the other colors already in use

kelseygonzalez commented 3 years ago

I can implement that @alex-r-bigelow ! Let me make the changes in the source. speaking of that, how's your javascript? This is made with tui calendar which has a way to hide weekends but I can't get the option to work because this (which was made using an API for it) is set up a little bit different. No pressure, but if you could figure it out I'd be grateful!

zoidy commented 3 years ago

@kelseygonzalez Cool looking calendar! If I can make a small suggestion, I'd recommend not including the entire source code for the library. It'd be better to include the script from their CDN. I can take a crack at figuring out the weekday thing.

zoidy commented 3 years ago

Ok, pull request created. It worked locally for me so hopefully it will work on the site

kelseygonzalez commented 3 years ago

I love the idea of not adding all of the library source code! As I said, I used an API to create this version and get kind of lost scrolling to see what's what (besides the part at the bottom with the workshops). However, @zoidy , I don't see a PR anywhere. Can you link to it here?

kelseygonzalez commented 3 years ago

@zoidy I think I see it - you forked my repo and just haven't made the PR yet. Keep in touch! I'd love to get this figured out (and especially removing the weekends, like I mentioned above!)

zoidy commented 3 years ago

@zoidy I think I see it - you forked my repo and just haven't made the PR yet. Keep in touch! I'd love to get this figured out (and especially removing the weekends, like I mentioned above!)

Here's the pull request. https://github.com/kelseygonzalez/resbaz2021schedule/pull/1

That's cool that there's a way to generate the calendar. Mind linking to the tool? I'm all for low-code solutions!

kelseygonzalez commented 3 years ago

Not sure why I wasn't notified of this message or the PR you sent, but I just merged them in! My goodness I'm so happy with how much better it looks @zoidy . It's such an improvement! Thanks so much.