search

reschke / xml2rfc

A formatter for the "xml2rfc" vocabulary, implemented in XSLT.
12 stars 5 forks source link

clean-for-DTD.xslt creates a warning in rfc2629.xslt #13

Closed martinthomson closed 7 years ago

martinthomson commented 7 years ago

INFO: No need to include 'Working Group' or 'Research Group' postfix in /rfc/front/workgroup value 'QUIC Working Group' (at line 32)

You should probably either remove the warning or the corresponding cleanup.

reschke commented 7 years ago

You mean clean up the source in the QUIC drafts? Will do.

martinthomson commented 7 years ago

I think that you misunderstood. The QUIC drafts are messed up, but that's not the issue.

Check out that warning. It is caused by clean-for-DTD mutating the <workgroup> element in a way that rfc2629 objects to.

martinthomson commented 7 years ago

It appears that you do the same cleanup twice. You add "Working Group" or "Research Group" in both xslt files. I would remove it from the former. I don't see anything in the preptool RFC regarding this, so you would be compliant.

reschke commented 7 years ago

But why do you run clean-for-DTD.xslt's output through rfc2629.xslt in the first place?

martinthomson commented 7 years ago

I don't know. It's your code (it's a revision of your pull request on the i-d-template code). I assumed that you had a reason for doing it.

reschke commented 7 years ago

Please be more specific. Are we discussing https://github.com/reschke/i-d-template/blob/master/main.mk ?

martinthomson commented 7 years ago

Sure, when I use that, this warning is what results. Is it invalid to clean then build?

reschke commented 7 years ago

Still don't understand. Look at

https://github.com/reschke/i-d-template/blob/master/main.mk#L56

that uses %.xml, not %.cleanxml.

martinthomson commented 7 years ago

OK, so I have an error in my usage. I see.