search

rescript-association / reanalyze

Experimental analyses for ReScript and OCaml: globally dead values/types, exception analysis, and termination analysis.
MIT License
277 stars 20 forks source link

Allow the package to be compiled on OCaml 4.12 #104

Closed kit-ty-kate closed 3 years ago

kit-ty-kate commented 3 years ago

The master branch currently compiles perfectly with the soon upcoming OCaml 4.12.

Would it be possible to get a release to get the compatibility with OCaml 4.11 and 4.12? I can release it on opam like last time if you need.

cristianoc commented 3 years ago

Were you able to build reason on ocaml 4.12 then build reanalyze with it? Tried quickly and even reason master does not seem to support 4.12 yet.

kit-ty-kate commented 3 years ago

Yes it compiles perfectly using this PR/branch: https://github.com/facebook/reason/pull/2635

If you use opam you can try adding this repository: https://github.com/kit-ty-kate/opam-alpha-repository/ and everything should be taken care of.

cristianoc commented 3 years ago

Thanks, I could build and things look fine. In fact, the typed ast is mostly unchanged between 4.11 and 4.12.

cristianoc commented 3 years ago

@kit-ty-kate creating release 2.12 now.