search

rescript-association / reanalyze

Experimental analyses for ReScript and OCaml: globally dead values/types, exception analysis, and termination analysis.
MIT License
277 stars 20 forks source link

Include Darwin arm64 builds in the NPM package #189

Closed Arden144 closed 1 year ago

Arden144 commented 1 year ago

Right now both the VSCode extension for ReScript and the NPM reanalyze package don't have any executables for arm64 devices

cristianoc commented 1 year ago

This should be doable following what the compiler does. CC @cknitt

cknitt commented 1 year ago

It seem the rescript-vscode CI already builds the ARM64 binary? https://github.com/rescript-lang/rescript-vscode/blob/dab2a95ae760d2a0f942348125664fc855b6b340/.github/workflows/ci.yml#L23

For this repo (reanalyze), the problem is that the ARM64 runner on our Mac Mini M1 is only added to the rescript-lang organization, not the rescript-association organization. (To make it availabe for the rescript-association organization, we would need to start a second runner instance on that machine which I would like to avoid.)

cristianoc commented 1 year ago

Sorry I did not pay attention this is the reanalyze project. Should update the readme. Development has moved inside the vscode extension. This repo is for use with opam.

Arden144 commented 1 year ago

It seem the rescript-vscode CI already builds the ARM64 binary? https://github.com/rescript-lang/rescript-vscode/blob/dab2a95ae760d2a0f942348125664fc855b6b340/.github/workflows/ci.yml#L23

For this repo (reanalyze), the problem is that the ARM64 runner on our Mac Mini M1 is only added to the rescript-lang organization, not the rescript-association organization. (To make it availabe for the rescript-association organization, we would need to start a second runner instance on that machine which I would like to avoid.)

My apologies for opening an issue in the wrong repo. I looked at the extension and it looks like it does build and ship an arm64 binary, but the extension code uses the wrong binary. I'll open an issue on the extension repo

cristianoc commented 1 year ago

Closing this as the discussion continues in the other repo.