search

rescript-association / reasonml.org

Deprecated in favor of rescript-lang.org
MIT License
125 stars 33 forks source link

Old mds files used + broken link #105

Closed Et7f3 closed 4 years ago

Et7f3 commented 4 years ago

screenshot from reasonml.org: image

and from reasonml.github.io: image

Also I was able to trigger a 404 error when clicking on the here I thought https://github.com/reason-association/reasonml.org/commit/adef6f32d93defbbc40d96cf39467112580f599e helped to prevent that.

ryyppy commented 4 years ago

You just found a bug in the link rendering logic, thanks.

Right now, the markdown renderer is removing all occurrences of .md(x)?$ in each link, this regex fails on anchored links, such as in this example: /docs/.../object.md#tip-tricks.

Will fix that

I thought adef6f3 helped to prevent that.

Yes it should, but the verification logic correctly strips away the .md from anchored links, since it has access to Node's path.parse function (which does the pathname extraction for you)

ryyppy commented 4 years ago

Tackling the old .md problem in #108