search

rescript-association / reasonml.org

Deprecated in favor of rescript-lang.org
MIT License
125 stars 34 forks source link

Add MDN references to String and String2. #162

Closed jdeisenberg closed 4 years ago

jdeisenberg commented 4 years ago
ryyppy commented 4 years ago

Looking good! I browsed through Js.String and Js.String2 and found a few other occurrences of Js.log and wondered if these are intentional. Namely:

Should we leave that as is?

jdeisenberg commented 4 years ago

There were some that my regex didn’t catch. I’ll fix those.

ryyppy commented 4 years ago

Finally got the time to have another look at this. Looking great, thanks!