rescript-association / reasonml.org

Deprecated in favor of rescript-lang.org
MIT License
125 stars 34 forks source link

Document pipelast #178

Closed wontheone1 closed 4 years ago

wontheone1 commented 4 years ago

Refer https://github.com/reason-association/reasonml.org/issues/177

wontheone1 commented 4 years ago

npm test worked all fine on my local machine but yarn bs:build && yarn dev gave me some error.

✗ yarn dev
yarn run v1.22.4
warning ../package.json: No license field
$ next
[ wait ]  starting the development server ...
[ info ]  waiting on http://localhost:3000 ...
Browserslist: caniuse-lite is outdated. Please run next command `yarn upgrade`
The static directory has been deprecated in favor of the public directory. https://err.sh/zeit/next.js/static-dir-deprecated
Warning: Built-in CSS support is being disabled due to custom CSS configuration being detected.
See here for more info: https://err.sh/next.js/built-in-css-disabled

> Using "webpackDevMiddleware" config function defined in next.config.js.
> Using external babel configuration
> Location: "/Users/wseobseo/reasonml.org/.babelrc"
[ error ] ./layouts/BeltDocsLayout.bs.js
Module not found: Can't resolve '../index_data/belt_api_index.json' in '/Users/wseobseo/reasonml.org/layouts'
[ event ] build page: /next/dist/pages/_error
[ wait ]  compiling ...
[ error ] ./layouts/BeltDocsLayout.bs.js
Module not found: Can't resolve '../index_data/belt_api_index.json' in '/Users/wseobseo/reasonml.org/layouts'
Error: Cannot find module '/Users/wseobseo/reasonml.org/.next/server/static/development/pages/_document'
Require stack:
- /Users/wseobseo/reasonml.org/node_modules/next/dist/next-server/server/load-components.js
- /Users/wseobseo/reasonml.org/node_modules/next/dist/next-server/server/api-utils.js
- /Users/wseobseo/reasonml.org/node_modules/next/dist/next-server/server/next-server.js
- /Users/wseobseo/reasonml.org/node_modules/next/dist/server/next.js
- /Users/wseobseo/reasonml.org/node_modules/next/dist/server/lib/start-server.js
- /Users/wseobseo/reasonml.org/node_modules/next/dist/cli/next-dev.js
- /Users/wseobseo/reasonml.org/node_modules/next/dist/bin/next
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:772:15)
    at Function.Module._load (internal/modules/cjs/loader.js:677:27)
    at Module.require (internal/modules/cjs/loader.js:830:19)
    at require (internal/modules/cjs/helpers.js:68:18)
    at Object.loadComponents (/Users/wseobseo/reasonml.org/node_modules/next/dist/next-server/server/load-components.js:24:25)
    at DevServer.findPageComponents (/Users/wseobseo/reasonml.org/node_modules/next/dist/next-server/server/next-server.js:528:60)
    at DevServer.renderErrorToHTML (/Users/wseobseo/reasonml.org/node_modules/next/dist/next-server/server/next-server.js:828:33)
    at DevServer.renderErrorToHTML (/Users/wseobseo/reasonml.org/node_modules/next/dist/server/next-dev-server.js:19:811)
    at processTicksAndRejections (internal/process/task_queues.js:85:5)
    at async DevServer.render (/Users/wseobseo/reasonml.org/node_modules/next/dist/next-server/server/next-server.js:513:22)
    at async Object.fn (/Users/wseobseo/reasonml.org/node_modules/next/dist/next-server/server/next-server.js:371:17)
    at async Router.execute (/Users/wseobseo/reasonml.org/node_modules/next/dist/next-server/server/router.js:132:32)
    at async DevServer.run (/Users/wseobseo/reasonml.org/node_modules/next/dist/next-server/server/next-server.js:486:29)
    at async DevServer.handleRequest (/Users/wseobseo/reasonml.org/node_modules/next/dist/next-server/server/next-server.js:138:20) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/wseobseo/reasonml.org/node_modules/next/dist/next-server/server/load-components.js',
    '/Users/wseobseo/reasonml.org/node_modules/next/dist/next-server/server/api-utils.js',
    '/Users/wseobseo/reasonml.org/node_modules/next/dist/next-server/server/next-server.js',
    '/Users/wseobseo/reasonml.org/node_modules/next/dist/server/next.js',
    '/Users/wseobseo/reasonml.org/node_modules/next/dist/server/lib/start-server.js',
    '/Users/wseobseo/reasonml.org/node_modules/next/dist/cli/next-dev.js',
    '/Users/wseobseo/reasonml.org/node_modules/next/dist/bin/next'
  ]
}

http://localhost:3000/ also show me Internal Server Error text.

Did I miss some steps? But I don't think this should be a problem in merging this PR.

cristianoc commented 4 years ago

This should go in the native section.

wontheone1 commented 4 years ago

@cristianoc Could you elaborate a little bit? (what do you mean by this? and why should it go to the native section)

I found where pipe-first is documented in this repo and added the corresponding changes for pipe-last.

wontheone1 commented 4 years ago

Reflected comments, or asked questions for the comments that I couldn't solve.

wontheone1 commented 4 years ago

Please review again, changed as suggested.

wontheone1 commented 4 years ago

@yawaramin @ryyppy Let me know if there is still changes to be done :)

wontheone1 commented 4 years ago

All comments addressed. This PR is ready to review again.

ryyppy commented 4 years ago

@wontheone1 You did a great job, thanks! Thanks @mlms13 / @yawaramin for the review!

yawaramin commented 4 years ago

Thanks @wontheone1 this is great!

wontheone1 commented 4 years ago

@ryyppy @mlms13 @yawaramin Thanks for the support! I learned a lot in the process!