fix: Add ; charset=utf-8 to headers.

rescript-association / reasonml.org

Deprecated in favor of rescript-lang.org

MIT License

125 stars 34 forks source link

fix: Add ; charset=utf-8 to headers. #186

Open Et7f3 opened 4 years ago

Et7f3 commented 4 years ago

this should fix encoding issue we see in embed on discord. https://vercel.com/docs/configuration#project/headers

Et7f3 commented 4 years ago

I have closed because I see same behaviour on discord computer and phone so it should be a discord bug.

Et7f3 commented 4 years ago

Others have fixed with the same fix https://devforum.roblox.com/t/error-with-unicodes-on-discord-embed/503516/11 and it seem that headers change only apply to blog/feed.xml so it seems I have failed my regex.

Et7f3 commented 4 years ago

Ok it works. before: before after: after So now maybe we should use another regex to match all html pages not only inside doc. Can we remove the meta tag (that set charset to utf-8) since it is in the headers now ?