Make it available on Windows

[kivi]

What do I need to do to make it work in Windows?

[mrmurphy]

I know almost nothing about Windows, can you help out here @prometheansacrifice?

[ManasJayanth]

Sure!

The PR I raised should append .exe and copy the binary correctly on Windows. But it looks like it hasn't been release to npm.

In the mean while, rename the binary in node_modules/bs-let/ppx to node_modules/bs-let/ppx.exe. Make sure .exe is present in the bsconfig.json too

{
  "ppx-flags": ["bs-let/ppx.exe"]
}

That should be it! Let us know if you run into any issues :)

[mrmurphy]

Ah I’m sorry! I wonder what’s stopping the release, that’s supposed to be automatic On Mar 10, 2020, 1:15 PM -0600, Manas notifications@github.com, wrote:

Sure! The PR I raised should append .exe and copy the binary correctly on Windows. But it looks like it hasn't been release to npm. In the mean while, rename the binary in node_modules/bs-let/ppx to node_modules/bs-let/ppx.exe. Make sure .exe is present in the bsconfig.json too { "ppx-flags": ["bs-let/ppx.exe"] } That should be it! Let us know if you run into any issues :) — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[kivi]

Thanks guys! There is a comment in the Readme: https://github.com/reasonml-labs/bs-let#notes about Windows. It needs to be moved from Travis to Azure? I am not understanding exactly why? Maybe that the exe-binary can be created on a Windows platform?

I have a project member using OSx, so that person won't be able to work if I change to .exe right? And that is that temporary issue until that PR is released, is that correct?

Where I can I inform myself about ppx on Windows or other platforms? Let me know if I could do something.

[ManasJayanth]

You shouldn't have trouble with .exe on MacOS

Indeed, the note in the Readme about Windows can be updated. The ppx works great there!

On Wed 11 Mar, 2020, 1:13 PM kivi, notifications@github.com wrote:

Thanks guys! There is a comment in the Readme: https://github.com/reasonml-labs/bs-let#notes about Windows. It needs to be moved from Travis to Azure? I am not understanding exactly why? Maybe that the exe-binary can be created on a Windows platform?

I have a project member using OSx, so that person won't be able to work if I change to .exe right? And that is that temporary issue until that PR is released, is that correct?

Where I can I inform myself about ppx on Windows or other platforms? Let me know if I could do something.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/reasonml-labs/bs-let/issues/24?email_source=notifications&email_token=AAXUDOXTQPX6QVQDG57XTCTRG46KXA5CNFSM4LFCZHI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOOPHGY#issuecomment-597488539, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXUDOROI7G7G5HMPIIX4FDRG46KXANCNFSM4LFCZHIQ .

[kivi]

I am getting following error:

Fatal error: exception Failure("bs-let/ppx.exe not found when resolving ppx-flags")

ls .\node_modules\bs-let\

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----        10/26/1985  10:15 AM       10180612 bs-let-darwin-x64.exe
-a----        10/26/1985  10:15 AM       15695336 bs-let-linux-x64.exe
-a----        10/26/1985  10:15 AM       13009635 bs-let-win-x64.exe
-a----        10/26/1985  10:15 AM           1381 copyPlatformBinaryInPlace.js
-a----         3/10/2020   5:04 PM           1270 package.json
-a----        10/26/1985  10:15 AM       13009635 ppx 

And obviously it works with: {"ppx-flags": [ "bs-let/bs-let-win-x64.exe" ]}

I could not try that on osx.

[ManasJayanth]

The binary ppx has to be renamed to ppx.exe in node_modules/bs-let

On Wed 11 Mar, 2020, 3:05 PM kivi, notifications@github.com wrote:

I am getting following error:

Fatal error: exception Failure("bs-let/ppx.exe not found when resolving ppx-flags")

ls .\node_modules\bs-let\

Mode LastWriteTime Length Name

---

-a---- 10/26/1985 10:15 AM 10180612 bs-let-darwin-x64.exe -a---- 10/26/1985 10:15 AM 15695336 bs-let-linux-x64.exe -a---- 10/26/1985 10:15 AM 13009635 bs-let-win-x64.exe -a---- 10/26/1985 10:15 AM 1381 copyPlatformBinaryInPlace.js -a---- 3/10/2020 5:04 PM 1270 package.json -a---- 10/26/1985 10:15 AM 13009635 ppx

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/reasonml-labs/bs-let/issues/24?email_source=notifications&email_token=AAXUDOQ6IPBGJB7NLTDRK6LRG5LMZA5CNFSM4LFCZHI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOOZ3AQ#issuecomment-597532034, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXUDOUAI4UBLS62PKDHZ53RG5LMZANCNFSM4LFCZHIQ .

[kivi]

Alright! rename the file not only change it in bsconfig.json. Thanks.

it works...