rescript-labs / decco

Bucklescript PPX which generates JSON (de)serializers for user-defined types
MIT License
226 stars 27 forks source link

Change package name, and move PPX executable #33

Closed mrmurphy closed 4 years ago

mrmurphy commented 4 years ago

Three things in this commit! I initially tried to split it into couple of commits, but changes ended up overlapping so I threw them all into one PR.

Notes on the moving of the PPX:

The current state of bucklescript ppxs is rather confusing, each having its own executable path. Every time the user wants to install a PPX, they have to check the readme to see what particular location they have to point to for the executable. With bs-let I moved the executable to the root level and named it ppx, so that when the user is installing, all they have to do is add package_name/ppx to the ppx flags to get it installed and working. If all bucklescript PPXs followed this pattern, users wouldn't need to refer to the readme at all after the first few times.

What do you think? @ryb73

ryb73 commented 4 years ago

Looks good! Just a couple comments.

mrmurphy commented 4 years ago

@ryb73 thanks for the review! I addressed your comments. Want to take another look?