search

rescript-labs / decco

Bucklescript PPX which generates JSON (de)serializers for user-defined types
MIT License
226 stars 27 forks source link

Add codec for Js.Dict.t #48

Closed jchavarri closed 4 years ago

jchavarri commented 4 years ago

Fixes #4.

jchavarri commented 4 years ago

@ryb73 thanks for the review :) I think I tackled all requests 👍 Do you mind taking another look please?

Edit: regarding using arrays + lists to generate the new dict, I used them because Js.Dict.t is not immutable, and I try to avoid mutations as much as possible, as I've suffered so much in the past. But I think in this case using same instance across the whole life of reducer is harmless.

mrmurphy commented 4 years ago

Muchisimas gracias, @jchavarri!