search

rescript-labs / decco

Bucklescript PPX which generates JSON (de)serializers for user-defined types
MIT License
227 stars 27 forks source link

Convert to PPXlib #68

Closed anmonteiro closed 3 years ago

anmonteiro commented 3 years ago

This PR converts decco to use ppxlib. The conversion is straightforward. I structured it into 2 commits:

  1. 0ffda3c upgrades the esy dependencies in ppx_src/package.json and commits the esy lockfile directory
  2. 229b04d upgrades the PPX to use ppxlib.

Note that, while we're building the PPX with OCaml 4.12, it works well with a current ReScript compiler (on 4.06) – ppxlib does the heavy lifting here.

Test plan

npm test passes.

ryb73 commented 3 years ago

Hey @anmonteiro thanks for the PR! Looking at it now.

I've noticed that Travis hasn't been picking up new PRs/branches for build. I think it may be because the repo was added to the reasonml-labs org? I sent a request to the org for Travis to access this repo, let me know if you see that request and/or are able to get Travis builds working for the org/repo. Thanks!

anmonteiro commented 3 years ago

Done

anmonteiro commented 3 years ago

Thanks @ryb73, I just fixed the CI build and addressed your comments.

ryb73 commented 3 years ago

Thanks @anmonteiro !