rescript-labs / decco

Bucklescript PPX which generates JSON (de)serializers for user-defined types
MIT License
228 stars 27 forks source link

Windows builds #74

Closed TheSpyder closed 3 years ago

TheSpyder commented 3 years ago

This extends #73, when I realised travis was running against my PR I decided to take a crack at using travis to build on windows.

It works! Fixes #20.

TheSpyder commented 3 years ago

Travis windows VMs don't support secure secrets very well 😭

I thought the build was hanging, so I temporarily deleted the deploy section, but it runs it just doesn't stream the live build info. However there is a risk of hanging. The only way to fix this is to disable filter_secrets, which runs the risk of secrets leaking: https://travis-ci.community/t/current-known-issues-please-read-this-before-posting-a-new-topic/264/10

From the looks of those docs anyone could set filter_secrets to false today and create a PR to echo the secret, so maybe it's not as much of a risk as it sounds.

I don't want to disable filter_secrets without approval, although it can be disabled only on windows, so for the moment this PR will just have a caveat that windows build progress can't be reported.

TheSpyder commented 3 years ago

Two things are currently failing

TheSpyder commented 3 years ago

@ryb73 this is good to go!