search

rescript-lang / rescript-core

A drop-in standard library for ReScript. Intended to be familiar for JavaScript developers, easy to use, and be rich enough (without being bloated) so that you don't need to reach for anything else for typical ReScript development.
MIT License
163 stars 30 forks source link

`Array.joinWith` -> `Array.join` #205

Closed cknitt closed 8 months ago

zth commented 8 months ago

I think this might be a bit problematic. While more correct, we're making the most common use case by far, which is passing an arg, more cumbersome to do.

I think we should just rename to join and have the arg still be an unlabeled string. That's the most common operation.

cknitt commented 8 months ago

Fine with me, too! Will update the PR.

cknitt commented 8 months ago

@zth Done! Please re-review. And could you also have a look at #201?