search

rescript-lang / rescript-vscode

Official VSCode plugin for ReScript
MIT License
329 stars 56 forks source link

Using "rename symbol" on labelled argument breaks #1004

Open JonoPrest opened 4 months ago

JonoPrest commented 4 months ago

When renaming a labelled arg, if you include the ~ it propogates to the renamed locations. If you remove it then it does not stay a labelled argument.

https://github.com/rescript-lang/rescript-vscode/assets/65739024/2486d2b2-0b05-49ff-b290-4710b48710a7

zth commented 4 months ago

Yeah, this is known and unfortunately a little bit difficult to fix. Some WIP prior art: https://github.com/rescript-lang/rescript-vscode/pull/872

JonoPrest commented 4 months ago

Yeah, this is known and unfortunately a little bit difficult to fix. Some WIP prior art: #872

Ah ok cool 👍🏼 not a big issue just thought I would flag if nobody else noticed.

zth commented 4 months ago

Yeah, we definitely want it fixed, so it's great that you report it 👍