Open Ashesh3 opened 1 year ago
@cknitt I am still having the same error in the latest pre-release version.
bash: /root/.vscode-server/extensions/chenglou92.rescript-vscode-1.7.7/server/analysis_binaries/linux/rescript-editor-analysis.exe: cannot execute binary file: Exec format error
uname -a
Linux e5c29417fc74 5.15.0-1016-oracle #20-Ubuntu SMP Mon Aug 8 07:08:08 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux
Oh, sorry, my bad! 😞 This issue is about Linux ARM, but my PR was about macOS ARM support. 🤦♂️
The problem with Linux ARM is that we have no CI setup / Github Actions runner for that platform.
Oh, sorry, my bad! 😞 This issue is about Linux ARM, but my PR was about macOS ARM support. 🤦♂️
The problem with Linux ARM is that we have no CI setup / Github Actions runner for that platform.
No worries 😄
Maybe this could help: https://github.com/marketplace/actions/arm-runner It seems it can run builds for armv6l, armv7l, aarch64 I can try to run it later once and check if it's usable in this scenario.
Why would we not support Linux ARM64 in the VSCode extension when the compiler supports it?
https://github.com/rescript-lang/rescript-compiler/blob/master/.github/workflows/ci.yml#L23-L27
The only issue I see is that the bundle gets too large, so we should switch to platform-specific extensions: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#platformspecific-extensions
Currently the binary file
rescript-editor-analysis.exe
fails to run on aarch64 architecture.Would it be possible to add support for aarch64?