search

rescript-lang / rescript-vscode

Official VSCode plugin for ReScript
MIT License
327 stars 55 forks source link

Semantic token: let keyword #978

Closed nojaf closed 4 months ago

nojaf commented 4 months ago

Hello,

I noticed that I'm not getting any special semantic token for the let keyword: image

Is this to be expected?

I do have it for open for example:

image

If this is a bug, I'm interested in sending a PR. But I could use some pointers on where to look for in the code.

DZakh commented 4 months ago

It uses storage.type grammar which is correct according to the document https://macromates.com/manual/en/language_grammars#naming_conventions.

Probably the issue with the theme not supporting storage.type.

nojaf commented 4 months ago

Oh, right. Spot on, thanks for clearing that up!