search

rescript-lang / rewatch

Rewatch is an alternative build system for the Rescript Compiler.
95 stars 12 forks source link

♻️ - Use package.path instead of manually constructing path part 2 #87

Closed DZakh closed 7 months ago

DZakh commented 7 months ago

It's a continuation of the change https://github.com/rolandpeelen/rewatch/commit/1647b2a6780ada2a360a574979d558c52f548ba1

I recreated the changes of the PR https://github.com/rolandpeelen/rewatch/pull/84, because it was easier than solving merge conflicts. Also, I didn't include the change where I start resolving path differently to support pnpm, I want to do it in a separate PR, since this one is already quite big.

jfrolich commented 7 months ago

The code looks great. I also tested it on our monorepo, and I couldn't find any obvious issues. LGTM!

DZakh commented 7 months ago

@jfrolich What about merging. I'd like to continue working on pnpm support

jfrolich commented 7 months ago

I think you can merge?

DZakh commented 7 months ago

No, only the maintainers of the repo can merge

DZakh commented 7 months ago
image
tsnobip commented 7 months ago

I would also appreciate if it could be merged and released, can't wait to try it on my setup!

DZakh commented 7 months ago

@tsnobip this is not a fix yet, but one step closer to it 😁

jfrolich commented 7 months ago

sorry for the confusion, we should make it possible to merge after approval. Merged now!

jfrolich commented 7 months ago

@rolandpeelen let's make @DZakh a maintainer!