search

rescript-lang / vim-rescript

MIT License
154 stars 15 forks source link

Omni completion doesn't work: complete/completion mismatch #56

Open ilaitinen opened 2 years ago

ilaitinen commented 2 years ago

vim-rescript tries to use complete:

https://github.com/rescript-lang/vim-rescript/blob/faeeb2deef1ad0ec67fc892ceeb9949f3bf2d77c/autoload/rescript.vim#L346

The underlying rescript-editor-analysis.exe expects completion:

https://github.com/rescript-lang/rescript-vscode/blob/master/analysis/src/Cli.ml#L66

ryyppy commented 1 year ago

Yeah that was a legit change from this commit which I didn't notice until now: https://github.com/rescript-lang/rescript-vscode/commit/d8183100dc58bb9c5efd3711c1fb3eae301ffa80

Since we are vendoring the language server right now, we may even change this right after updating to the latest LSP.