change response type from object to records

rescript-react-native / image-picker

ReScript bindings for react-native-image-picker

MIT License

8 stars 2 forks source link

change response type from object to records #4

Closed a-c-sreedhar-reddy closed 4 years ago

a-c-sreedhar-reddy commented 4 years ago

With new version of bs records get compiles to objects.

DCKT commented 4 years ago

This is a breaking change feature, we should release a new npm version

@MoOx Can you add this package on npm 😄 thanks !

a-c-sreedhar-reddy commented 4 years ago

@MoOx @phamhoaivu911 made data optional.

MoOx commented 4 years ago

How do you feel we release this as a patch release to keep the version number close to the original lib? This is definitely a breaking change, but very easy to adjust right?

phamhoaivu911 commented 4 years ago

It's ok for me 👌

MoOx commented 4 years ago

2.3.2 is out, sorry for the delay