rescript-react-native / rescript-react-navigation

ReScript bindings for React Navigation
MIT License
74 stars 28 forks source link

Fix package name. #1

Closed cknitt closed 5 years ago

MoOx commented 5 years ago

I was wondering if we wanted to go this way since we already cut a release with the other name. Same for "core" package.

cknitt commented 5 years ago

I am leaning towards using @reason-react-native/* without exception.

I'd find it weird to have "mixed" names in my project's package.json, like

"dependencies": {
    "@reason-react-native/async-storage": "...",
    "@reason-react-native/deviceInfo": "...",
    "@reason-react-native/keychain": "...",
    // ... many other dependencies ...
    "reason-react-native": "...",
    "reason-react-native-navigation": "...",
    // ...
}
MoOx commented 5 years ago

Make sense. How should we rename reason-react-native then?

cknitt commented 5 years ago

I would say @reason-react-native/react-native.

MoOx commented 5 years ago

Oh good idea, it's simple.

Btw do we want to rename the repo "navigation" (& same for core repo) so repo match package name all the time?

MoOx commented 5 years ago

Hum never mind for navigation, I was thinking the package name was @reason-react-native/navigation. Maybe that could seems inconsistant to sometimes have a short name (without react-(native-)) and sometimes not.

cknitt commented 5 years ago

It would be great to have the repo name always match the package name.

I just adapted the package name to the repo name though (@reason-react-native/react-navigation). If we want just /navigation instead of /react-navigation, we need to change both.

MoOx commented 5 years ago

/navigation would be good for me.

Exception would be react-native core bindings themselves I guess?

cknitt commented 5 years ago

That's fine with me!

MoOx commented 5 years ago

Will do the change soon & will notify everyone on discord when it's done.