search

rescript-react-native / rescript-react-navigation

ReScript bindings for React Navigation
MIT License
74 stars 28 forks source link

Bump bs-platform from 5.2.0 to 7.0.1 #22

Closed smorimoto closed 4 years ago

MoOx commented 4 years ago

Hi @imbsky, thanks for raising this. What would be nice while we are doing this upgrade is to also simplify all Js.t types like this https://github.com/reason-react-native/reason-react-navigation/blob/c76161627d9986d86e6abcadfcfa7e15bb1d4cd8/src/Navigation.re#L4-L11 to remove them since now records are encoded as js objects!

Something similar has been started for reason-react-native: https://github.com/reason-react-native/reason-react-native/pull/631

smorimoto commented 4 years ago

Hi @MoOx, I made some changes. I'm not used to BuckleScript, is there anything else I should change?

smorimoto commented 4 years ago

Sorry for the late response, I just updated it!

MoOx commented 4 years ago

I have made a similar change to v5 branch but I named it v5-bs7. Not sure how we want to got with the 5/7 strategy (following https://github.com/reason-react-native/reason-react-native/pull/631)...