search

rescript-react-native / rescript-react-navigation

ReScript bindings for React Navigation
MIT License
74 stars 28 forks source link

Support react-navigation 4.0.x (breaking change). #3

Closed cknitt closed 5 years ago

cknitt commented 5 years ago

I assume this will also break the example. After this + all the repo/package renaming is through, we should get the example to work again.

MoOx commented 5 years ago

Should we split into several bindings (packages/repo?) Would make sense even if "annoying" to handle?

cknitt commented 5 years ago

For the npm package, having version numbers that match the react-navigation version should be sufficient. In the repo, we could keep a v3 branch, and use the master branch for 4.x.

MoOx commented 5 years ago

I may not expressed myself correctly.

I was more thinking about react-navigation-drawer, -stack & -tabs

cknitt commented 5 years ago

Ah, right, sorry.

I think it's not worth the effort to have separate repos/npm packages for those, that would only complicate things further both for users and for us.

MoOx commented 5 years ago

I agree but people might looks for a given things & not look for it. We could try to rename DrawerNavigator & friends to ReactNavigationDrawer maybe?

cknitt commented 5 years ago

Yes, that's a good idea! I'll do this in a follow-up PR.

cknitt commented 5 years ago

@MoOx Regarding renaming: I forgot that we already have the namespace ReactNavigation set in bsconfig.json. So if we renamed DrawerNavigator as suggested, it would become ReactNavigation.ReactNavigationDrawer.

Or I would need to "namespace everything manually" instead of via bsconfig.json which I don't really want. So I'd rather keep things as they are.

MoOx commented 5 years ago

Oh yeah. I guess documentation should be ok. We could also go for ReactNavigation.Drawer.