Missing options props - Githubissues

rescript-react-native / rescript-react-navigation

ReScript bindings for React Navigation

MIT License

74 stars 28 forks source link

Missing options props #35

Closed Freddy03h closed 4 years ago

Freddy03h commented 4 years ago

Add and removing props and options regarding react-navigation v5 documentation.

Freddy03h commented 4 years ago

I tried those changes on my own project this week-end, it work well :)

fix tabBar : function that return an element instead of being a component (my previous PR about it was a bit rushed ^^' )
add the view MaterialTopTabBar in MaterialTopTabs
add and remove many props and options on MaterialTopTabs, BottomTabs and Stack

For the peerDependencies I think we should add all the dependencies? But at least remove /core because it's now recommended to not add it (only add /native). Should I replace it with native only or should I add all other dep ? (stack, tabs, drawer, etc)

Freddy03h commented 4 years ago

I didn't tried all the new props/options, but I'm pretty confident about the ones I removed from MaterialTopTabs

MoOx commented 4 years ago

For the peer deps yes, please do what is recommended, so only what user should have as deps :) And all of them. Worst case scenario is that you get a warning for a dep you don't use, that's acceptable for now

As soon as you do that, I will adjust the version according to this... Since we don't "match" a single dep, the version number will be different that what we do for other packages.

Freddy03h commented 4 years ago

Updated peerDependencies to this:

  "peerDependencies": {
    "@react-navigation/native": "^5.0.0",
    "@react-navigation/bottom-tabs": "^5.0.0",
    "@react-navigation/stack": "^5.0.0",
    "@react-navigation/material-top-tabs": "^5.0.0",
    "@react-navigation/material-bottom-tabs": "^5.0.0",
    "@react-navigation/drawer": "^5.0.0",

Regarding all packages changelog, it almost bugfixes, and features are almost typescript definitions and listeners things. There is a somes features linked to a specific minor version of a packaged but we don't supported them yet. So I think it's better to keep the 5.0.0 for the minimum version.

MoOx commented 4 years ago

Your PR is still in Draft, do you have other things to push or is it ready as it is?

Freddy03h commented 4 years ago

Nothing else to push for now ^^

Freddy03h commented 4 years ago

Thank you!