search

rescript-react-native / rescript-react-navigation

ReScript bindings for React Navigation
MIT License
74 stars 28 forks source link

Combine AppContainerFunctor and AppContainer again, get example to run. #7

Closed cknitt closed 5 years ago

cknitt commented 5 years ago

  1. I combined AppContainerFunctor and AppContainer again. This is less awkward, and if not using the functor, usage will still be zero-cost as the file won't be imported.

  2. I updated the example so that the Reason code builds at least. However, using yarn link, I couldn't get Metro to find @reason-react-native/navigation. I think the simplest solution would be to move the example to another repo @reason-react-native/navigation-example.

MoOx commented 5 years ago

And for 2 (moving example) that can be a nice idea as we could make this a react native template so people can start with that!

MoOx commented 5 years ago

https://github.com/reason-react-native/navigation-example