rescript-react-native / template

ReScript React Native template
MIT License
23 stars 7 forks source link

feat: upgrade template to use RN 0.62 #5

Closed Naturalclar closed 4 years ago

Naturalclar commented 4 years ago

Getting ready to make template for RRN + React Native 0.62

Used UpgradeHelper for diffs

Naturalclar commented 4 years ago

@MoOx

Any reason why the entire diff in ios/ProjectName.xcodeproj/project.pbxproj is not visible on the helper?

The diff is too large, so it's folded. You can still click on the arrow to see the diff, or click on View File to see the file

Screen Shot 2020-03-31 at 12 27 03 AM

We should merge & release only after a new release of run 0.62

I agree, this is just preparing for the release :+1:

MoOx commented 4 years ago

Oh I missed that :D

🤙

idkjs commented 4 years ago

@MoOx I went ahead and fix the conflict. Do we want to merge this?

MoOx commented 4 years ago

Try 0.62.1 & tell me if that's better :)

MoOx commented 4 years ago

I was sure I merged this before releasing, I am so stupid 😇