search

rescript-react-native / webview

ReScript bindings for react-native-webview
MIT License
8 stars 4 forks source link

Build error #2

Closed mununki closed 2 years ago

mununki commented 3 years ago

The problem

Build error

How to reproduce

Steps to reproduce:

  1. Init rescript react native with the latest version. Then install react-native-webview & rescript-react-native/webview and build

Expected behavior

Build successfully

Actual behavior

FAILED: src/ReactNativeWebView.cmj

  We've found a bug for you!
  /Users/w/Documents/projects/Countube/node_modules/@rescript-react-native/webview/src/ReactNativeWebView.res:81:23-34

  79 │
  80 │ module WebViewErrorEvent = {
  81 │   type payload = Js.t<webViewError>
  82 │   include Event.SyntheticEvent({
  83 │     type _payload = payload

  This type webViewError should be an instance of type {..}

FAILED: cannot make progress due to previous errors.
Failure: /Users/w/Documents/projects/Countube/node_modules/rescript/darwin/ninja.exe
Location: /Users/w/Documents/projects/Countube/node_modules/@rescript-react-native/webview/lib/bs
error Command failed with exit code 2.

Environment

"dependencies": {
  "@rescript-react-native/webview": "^10.8.1",
  "@rescript/react": "^0.10.3",
  "react": "17.0.1",
  "react-native": "0.64.2",
  "react-native-webview": "^11.6.5",
  "rescript-react-native": "^0.64.3"
},
cknitt commented 2 years ago

Fixed that yesterday in #6 (without realizing that there already was an existing PR #3 to fix that 🤦).