search

rescriptbr / reform

📋 Reasonably making forms sound good
https://rescript-reform.netlify.app/
MIT License
353 stars 41 forks source link

fix: add render to useMemo deps in Field #190

Closed a-gierczak closed 2 years ago

a-gierczak commented 4 years ago

This should fix #155. This doesn't extend Field functionality but gives user an option to provide memoized render (e.g. via useCallback) if theirs use case requires it. Also we get rid of annoying bug where Field would render with stale renderProp by default.

fakenickels commented 4 years ago

Hey there, thanks for your PR. We are still analyzing the best way to opt-out from the current behavior of Field. Our internal codebase makes very heavy usage of the current behavior of Field only listening to changes related to its watched field

vmarcosp commented 2 years ago

@fakenickels can we close this PR since that passed 2 years form the last changes?

fakenickels commented 2 years ago

better close it for now and rediscuss if necessary