search

rese1f / MovieChat

[CVPR 2024] 🎬💭 chat with over 10K frames of video!
https://rese1f.github.io/MovieChat/
BSD 3-Clause "New" or "Revised" License
454 stars 37 forks source link

Unused positional embeddings #24

Closed minostauros closed 8 months ago

minostauros commented 8 months ago

https://github.com/rese1f/MovieChat/blob/340bbde07f0d7fbbc8cfdfd6d7fd975d7ccc955f/MovieChat/models/moviechat.py#L309

is overwritten by

https://github.com/rese1f/MovieChat/blob/340bbde07f0d7fbbc8cfdfd6d7fd975d7ccc955f/MovieChat/models/moviechat.py#L319

Positional embeddings are expanded with p, u, and q, so the line 309 may be safely removed.

Espere-1119-Song commented 8 months ago

Thanks for your contribution to the code, I will fix it in the next version of MovieChat code.