research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation
https://research.software
25 stars 14 forks source link

879 - public profile page #1057

Closed dmijatovic closed 11 months ago

dmijatovic commented 11 months ago

Public profile page (using opt-in approach)

Closes #879 Closes #1017

Changes proposed in this pull request:

We should also test locally with the real RSD data from the backup in order to identify possible corner cases.

How to test:

User settings - authentication methods

image

User settings - enable public profile

image

Link to public profile page (link icon shown next to name)

image

Public profile page

image

Empty public profile page

image

PR Checklist:

dmijatovic commented 11 months ago

I moved this PR to draft because few changes are agreed to be implemented:

jmaassen commented 11 months ago

Some initial comments:

(more later)

dmijatovic commented 11 months ago

@jmaassen Thanks for the feedback. I did following adjustments:

@ewan-escience Can you extend data-generation module to create few random profiles for testing?

sonarcloud[bot] commented 11 months ago

[rsd-database] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] commented 11 months ago

[authentication] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

dmijatovic commented 11 months ago

I improved label based on Jasons advice. @cmeessen, @jcohen02 We would like to include this PR into next release tomorrow. Are there any objections to including this feature in the release tomorrow? My apology for a very short notice.

sonarcloud[bot] commented 11 months ago

[rsd-frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

27.8% 27.8% Coverage
0.0% 0.0% Duplication

jcohen02 commented 11 months ago

I improved label based on Jasons advice. @cmeessen, @jcohen02 We would like to include this PR into next release tomorrow. Are there any objections to including this feature in the release tomorrow? My apology for a very short notice.

No objections from my side. As I understand it, this won't affect anything in the existing setup - it only has an effect if the user decides to authenitcate via ORCID and to enable a public profile page?

dmijatovic commented 11 months ago

No objections from my side. As I understand it, this won't affect anything in the existing setup - it only has an effect if the user decides to authenticate via ORCID and to enable a public profile page?

Yes, that is correct. The ORCID authentication need to be defined in .env file in order to enable linking of ORCID. If info is not provided the button Link you ORCID account and the switch Enable public profile will not be shown.

Thanks for the swift reaction.