Closed dmijatovic closed 11 months ago
I moved this PR to draft because few changes are agreed to be implemented:
Some initial comments:
(more later)
@jmaassen Thanks for the feedback. I did following adjustments:
@ewan-escience Can you extend data-generation module to create few random profiles for testing?
[rsd-database] Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
[authentication] Kudos, SonarCloud Quality Gate passed!
I improved label based on Jasons advice. @cmeessen, @jcohen02 We would like to include this PR into next release tomorrow. Are there any objections to including this feature in the release tomorrow? My apology for a very short notice.
[rsd-frontend] Kudos, SonarCloud Quality Gate passed!
I improved label based on Jasons advice. @cmeessen, @jcohen02 We would like to include this PR into next release tomorrow. Are there any objections to including this feature in the release tomorrow? My apology for a very short notice.
No objections from my side. As I understand it, this won't affect anything in the existing setup - it only has an effect if the user decides to authenitcate via ORCID and to enable a public profile page?
No objections from my side. As I understand it, this won't affect anything in the existing setup - it only has an effect if the user decides to authenticate via ORCID and to enable a public profile page?
Yes, that is correct. The ORCID authentication need to be defined in .env file in order to enable linking of ORCID. If info is not provided the button Link you ORCID account
and the switch Enable public profile
will not be shown.
Thanks for the swift reaction.
Public profile page (using opt-in approach)
Closes #879 Closes #1017
Changes proposed in this pull request:
We should also test locally with the real RSD data from the backup in order to identify possible corner cases.
How to test:
make start
to build app an create test itemsprofessor1
for exampleLink your ORCID account
button (see image 1).http://localhost/profile/{YOUR ORCID}/software
. This should result in 404.User settings - authentication methods
User settings - enable public profile
Link to public profile page (link icon shown next to name)
Public profile page
Empty public profile page
PR Checklist:
docker-compose.yml