research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation
https://research.software
23 stars 15 forks source link

Status report of background services for software #1070

Closed dmijatovic closed 8 months ago

dmijatovic commented 8 months ago

Status report of background services

To test background services you will need to have properly defined service items in the .env file. Some might require secret to enable service to scrape information using "less restricted" quota.

Changes proposed in this pull request:

How to test:

Background services (scheduled - initial state)

image

Background services (not active state)

image

Background services (error state)

image

Background services (multiple package managers)

image

PR Checklist:

jmaassen commented 8 months ago

I tested this PR and have some comments. Unsure if this originates in the scrapers of frontend. My setup is an RSD with a single software and the following info:

Repo: https://github.com/GooglingTheCancerGenome/sv-callers

Package managers: https://anaconda.org/conda-forge/esmvaltool https://pypi.org/project/ESMValTool/ https://hub.docker.com/r/esmvalgroup/esmvaltool https://cran.r-project.org/web/packages/GGIR https://mvnrepository.com/artifact/nl.junglecomputing/sbbi-upnplib https://www.npmjs.com/package/aws-sdk

I see the many of the scrapers running successfully after leaving the RSD for some time. Some never seem to run however:

Screenshot 2023-12-19 at 16-59-41 Edit software Research Software Directory

As a user, it is difficult to figure out if the scrapers hasn't run because of some mistake I have made, or because of some external reason (waiting for my turn, scraper did too many requests, scraper only runs once a day, a missing scraper, etc.). Would there be a way to make this more clear?

Unrelated: I noticed that when making a mistake when cutting and pasting a package manager URL, the PM detection sometimes fails. For example:

dmijatovic commented 8 months ago

Thanks for the feedback @jmaassen. I have fixed repository stats flag (was not correct) and removed package manager services that are not implemented (yet). I made force push, please remove old local branch and pull again.

image

jmaassen commented 8 months ago

The feedback provided about the services is now much better. A few other comments:

I would change the text in this text box:

Screenshot 2023-12-28 at 10-28-59 Edit software Research Software Directory

to:

No information about package managers is provided for this software

And this one:

Screenshot 2023-12-28 at 10-29-10 Edit software Research Software Directory

to:

The RSD collects additional information about your software using the links you
have provided. For example, the software repository URL is used to collect 
information about the commit history and programming languages, and a 
package manager URL can be used to retrieve download numbers.  

This section provides feedback if the RSD could succesfully retrieve 
this information or if it has encountered an error. These may be cause by 
a URL that is missing or incorrect. 

Please contact us at rsd@esciencecenter.nl in case you need our 
assistance in solving any of the errors.

There is also a typo here:

Screenshot 2023-12-28 at 10-48-23 Edit software Research Software Directory

"Commit hisitory" should be "Commit history". I would also use the full "Repository statistics" instead of "Repository stats"

For these two:

Screenshot 2023-12-28 at 10-47-58 Edit software Research Software Directory

Screenshot 2023-12-28 at 10-48-13 Edit software Research Software Directory

I think that the "public api" bit in the subtitle is not that useful for the average user? Maybe its better to say:

Additional information extracted using the source code repository URL

and

Additional information extracted using package manager URLs 
dmijatovic commented 8 months ago

@jmaassen Thanks for the feedback. I improved the messages and rebased this PR to the latest main (to include updates of Next and Node).

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed for 'rsd-frontend'

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
0.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud