research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation

https://research.software

23 stars 15 forks source link

1072 profile counters #1074

Closed dmijatovic closed 8 months ago

dmijatovic commented 8 months ago

Improve profile features

Closes #1072

Changes proposed in this pull request:

Fix software and project counts on the profile page when using pagination
Add link to contact person name when profile page is enabled

How to test:

make start to build app and generate test data
navigate to software or project page and find person with the link
navigate to profile page. Look for the profile pages that have more than 12 items so you can use pagination.
confirm that software and project counts are consistent while navigating to 2nd,3rd software/project page.
look for the contact person that has profile enabled (or make one contact with profile page as contact person) and confirm that it has link to profile page on software and project page

Example contact person link

PR Checklist:

[ ] Increase version numbers in docker-compose.yml
[ ] Link to a GitHub issue
[ ] Update documentation
[ ] Tests

sonarcloud[bot] commented 8 months ago

Quality Gate passed for 'rsd-frontend'

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud