research-software-directory / RSD-as-a-service

This repo contains the new RSD-as-a-service implementation

https://research.software

23 stars 15 forks source link

fix: broken icon for other package managers #1080

Closed dmijatovic closed 8 months ago

dmijatovic commented 8 months ago

Fix broken icon for other package managers

Closes #1077

Changes proposed in this pull request:

When link to a software package is provided to the package manager that are not "supported" with the logo we show first 3 letters of the hostname instead of the icon (see image below)
Increase margins in the commit line chart to show complete year at the first/last label

How to test:

make start to build and generate test data
login as rsd_admin, use RSD_ENVIRONMENT=dev in .env file to promote first user logged into rsd_admin role
select first software from the list and go to edit package manager section. Enter unknown package manager links like:
- https://packages.debian.org/search?keywords=libcdk-java
- https://central.sonatype.com/artifact/org.openscience.cdk/cdk-bundle/overview
confirm that links are shown as squares with first 3 letters of the hostname for examples
try adding "supported" package managers like CRAN, Maven etc and confirm that these are loaded with proper logos
for testing commit chart last label you can use CDK repo https://github.com/cdk/cdk

Example package manager links on software page

Example commit chart improved last label

Current
Improved

PR Checklist:

[ ] Increase version numbers in docker-compose.yml
[ ] Link to a GitHub issue
[ ] Update documentation
[ ] Tests

sonarcloud[bot] commented 8 months ago

Quality Gate passed for 'rsd-frontend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
15.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jmaassen commented 8 months ago

Can you also add the missing logos? For debian we can use this one:

https://commons.wikimedia.org/wiki/File:Debian_logo.png

For sonatype there's this one:

https://www.sonatype.com/hs-fs/hubfs/Logo%20-%202019/SON_logo_main_vertical@2x-trimmed.jpg?width=1124&name=SON_logo_main_vertical@2x-trimmed.jpg

It can also be found in their press kit: https://www.sonatype.com/hubfs/Sonatype%20Corporate%20Logos.zip

jmaassen commented 8 months ago

Two more we can add (from the production data):

https://community.chocolatey.org/packages/openchrom https://snapcraft.io/openchrom

dmijatovic commented 8 months ago

@jmaassen Let's merge this PR as fix for other. I will create new issue for adding support (icons) for additional package managers.